+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38949/31390

• This PR adds an extra 16KB to repository

A new Pull Request was created by @revering for master.

It involves the following packages:

• SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild, please test for CMSSW_12_5_G4VECGEOM_X

@revering , please, add he fix of G4muDarkBremsstahlungModel: substitute

element->GetA() by element->GetN()

and

double muMass = dp->GetDefinition()->GetPDGMass();

instead of hardcoded muon mass.

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38949/31395

• This PR adds an extra 20KB to repository

Pull request #38949 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

I've implemented the change to GetN() and using the Geant4 muon particle definition to get the muon mass instead of a hardcoded value. The muon mass is used in many functions, so I added it as a class member and initialized it with
muonMass = G4MuonMinus::MuonMinusDefinition()->GetPDGMass() / CLHEP::GeV
instead of using the dynamic particle.

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38949/31396

• This PR adds an extra 20KB to repository

Pull request #38949 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@revering Please also backport this to 12_4_X

please test

+1

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@revering , please make modification in 10_6 PR, make also backport of this PR to 12_4.

+1

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72030c/26615/summary.html
COMMIT: 84f5634
CMSSW: CMSSW_12_5_X_2022-08-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38949/26615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3677948
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3677912
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found